Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added velocity and effort joint testing #29

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Added velocity and effort joint testing #29

wants to merge 23 commits into from

Conversation

hijimasa
Copy link

Sorry for the delay.

  • Added a test for velocity and effort joints.
  • Added test that commands are output separately for position, velocity, and effort joints.
  • Removed unnecessary processing as a result of testing with Isaac Sim.

hijimasa and others added 23 commits May 31, 2024 10:10
@hijimasa
[add] check velocity command exists to publish command
c602929 
[change] separate position/velocity/effort command
[change] use mimic joint name to publish command
@hijimasa
[fix] fixed bug about mimic joint only publish position
c8c3165
@hijimasa
[remove] remove unnecessary warining
82ae31f
@hijimasa
allow hardware parameter to allow initialising joint commands with ro…
2b23e6c 
…bot starting state
@hijimasa
[add] add wait_for_reaching_initial_values parameter
6dccdc0
@hijimasa
[fix] Fixed a bug that caused joints to return to their original posi…
ffa421f 
…tion after being moved to the initial position.
@hijimasa
Revert "allow hardware parameter to allow initialising joint commands…
ab71778 
… with robot starting state"

This reverts commit 2b23e6c.
@JafarAbdi
Add ruff/ruff format to pre-commit & Add integration test
1205b10
@JafarAbdi
Set joint_states_ to initial_value as well
a6486ff
@JafarAbdi
Update comments
bf1194f
@JafarAbdi
Update test depends
ffd1daa
@JafarAbdi
Linter
a73a22a
@JafarAbdi
Add xacro as exec depend
adb300a
@JafarAbdi
More dependencies
d912cca
@JafarAbdi
Add xml linter
69b46f6
@JafarAbdi
Convert all depend to test_depend
85dcc27
@JafarAbdi
More dependencies
bc5fe4d
@hijimasa
Merge branch 'for_mobile_robot_with_isaac_sim' into HEAD
aaf603b
@hijimasa
[fix] Modifications to pass test
15d984f
@hijimasa
[add] Ignore test temporary files
047df3e
@hijimasa
[add] add diffbot_with_rrr to test velocity and effort joint
c7f9431
@hijimasa
[add] add velocity and effort test
9131012
@hijimasa
[fix] Tested with Isaac Sim and confirmed that it was an unnecessary …
197f424 
…process, so it was removed.Tested with Isaac Sim and removed as it was an unnecessary process.
@JafarAbdi JafarAbdi self-requested a review October 31, 2024 12:04
@JafarAbdi
Copy link
Collaborator

Thanks @hijimasa for the tests, I'll take a look this week!

@hijimasa
Copy link
Author

Hi @JafarAbdi , Could I help you.

@JafarAbdi
Copy link
Collaborator

Hi @JafarAbdi , Could I help you.

Sorry for the delay, I travelled a lot in the last few weeks 😢 . I'll review it asap, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hijimasa @JafarAbdi